Skip to content

update to electron v37#2260

Merged
sawka merged 2 commits intomainfrom
sawka/update-electron-aug2025
Aug 19, 2025
Merged

update to electron v37#2260
sawka merged 2 commits intomainfrom
sawka/update-electron-aug2025

Conversation

@sawka
Copy link
Member

@sawka sawka commented Aug 15, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 15, 2025

Walkthrough

  • Adds a new Taskfile task: outdated (runs “yarn dlx npm-check-updates” with a description).
  • Updates docs/package.json: downgrades eslint and @eslint/js to ^8.57.0; adds @types/react and @types/react-dom (^18.3.0).
  • Updates emain/emain.ts: extends startup log to include Electron version via process.versions.electron.
  • Updates root package.json: bumps multiple devDependencies (@vitejs/plugin-react-swc ^4, electron ^37.3.0, electron-vite ^4, vite ^6.0.0, plugins), updates sharp to ^0.34.0, downgrades eslint and @eslint/js to ^8.57.0, and adds a resolutions entry for node-abi ^4.6.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/update-electron-aug2025

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
emain/emain.ts (1)

76-84: Startup log addition looks correct; placeholder/argument counts match.

The new electron=%s placeholder is paired with process.versions.electron, and the total 7 %s specifiers match the 7 arguments. No functional risk.

Optional: consider including Node and Chrome versions for faster triage:

  • node=%s via process.versions.node
  • chrome=%s via process.versions.chrome

Apply this diff if you want to include them:

-        "waveterm-app starting, data_dir=%s, config_dir=%s electronpath=%s gopath=%s arch=%s/%s electron=%s",
+        "waveterm-app starting, data_dir=%s, config_dir=%s electronpath=%s gopath=%s arch=%s/%s electron=%s node=%s chrome=%s",
         waveDataDir,
         waveConfigDir,
         getElectronAppBasePath(),
         getElectronAppUnpackedBasePath(),
-        unamePlatform,
-        unameArch,
-        process.versions.electron
+        unamePlatform,
+        unameArch,
+        process.versions.electron,
+        process.versions.node,
+        process.versions.chrome
docs/package.json (1)

42-49: ESLint/tooling versions now align to 8.57; verify @types/eslint v9 compatibility.

  • Downgrading eslint and @eslint/js to ^8.57.0 is consistent with root; good.
  • @types/eslint remains at ^9.x (Line 44, unchanged). This can be fine, but please verify your ESLint config/plugins don’t rely on ESLint 9 APIs.

Also, you added @types/react and @types/react-dom at ^18.3.x while runtime deps are react/react-dom ^18.0.0. Consider aligning runtime to ^18.3.x in docs to avoid subtle type gaps.

If you want to align React versions in docs, update these fields (outside the hunk):

{
  "dependencies": {
    "react": "^18.3.1",
    "react-dom": "^18.3.1"
  }
}
Taskfile.yml (1)

265-268: Include workspaces in npm-check-updates to cover docs and any future packages.

ncu supports scanning workspaces; running it only at the root can miss nested package.json files. Recommend using the workspaces flag.

Apply this diff:

 outdated:
   desc: Check for outdated packages using npm-check-updates.
-  cmd: yarn dlx npm-check-updates
+  cmd: yarn dlx npm-check-updates --workspaces
package.json (1)

65-69: Electron 37 + electron-vite 4 bump: looks good; consider removing @types/electron.

  • Upgrading electron to ^37.3.0 and electron-vite to ^4.0.0 is coherent with the main log change and Vite 6. No functional issues spotted here.
  • Electron ships its own TypeScript types. Keeping @types/electron (Line 49, unchanged) can cause type drift/conflicts after bumps like this. Consider removing @types/electron unless you have a specific reason to keep it.

If you decide to remove it, also refresh types with a clean install (yarn && ts --project checks).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c834b67 and 3b92cb2.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • Taskfile.yml (1 hunks)
  • docs/package.json (1 hunks)
  • emain/emain.ts (1 hunks)
  • package.json (5 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
emain/emain.ts (1)
emain/platform.ts (4)
  • getElectronAppBasePath (260-260)
  • getElectronAppUnpackedBasePath (261-261)
  • unamePlatform (270-270)
  • unameArch (269-269)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build for TestDriver.ai
  • GitHub Check: Build Docsite
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: merge-gatekeeper
🔇 Additional comments (2)
package.json (2)

170-172: Resolutions for esbuild and node-abi are pragmatic; just ensure rebuild pipeline is green.

Pinning esbuild to ^0.25 is aligned with Vite 6 expectations. Adding node-abi ^4.6.0 both as a devDependency and a resolution helps native rebuilds (e.g., sharp) match Electron 37 ABI. Looks fine—just verify electron-builder install-app-deps runs clean across platforms.

If issues crop up on CI or user machines, consider documenting a “clean native rebuild” step:

  • yarn run electron-builder install-app-deps
  • Remove cached prebuilds if necessary.

152-152: Sharp ^0.34.0 upgrade: confirm Electron 37 prebuild availability across targets.

Sharp relies on libvips and prebuilt binaries; with Electron 37’s ABI, ensure prebuilds are available for your target OS/arch matrix. If not, the node-abi resolution plus install-app-deps should rebuild locally.

Consider running a packaging dry-run on macOS (arm64/x64), Windows, and Linux to spot native module ABI mismatches early.

@sawka sawka merged commit 559ed2e into main Aug 19, 2025
8 of 10 checks passed
@sawka sawka deleted the sawka/update-electron-aug2025 branch August 19, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant